Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first draft of "Show diff"(Help me pls!) #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Asalle
Copy link

@Asalle Asalle commented Jan 17, 2020

Fixes #633

Hello,
i wanted to add a simple window that shows diff between local notebook and remote one if a merge confict occurs (see issue). This is an early draft of what could it look like. I could find a way to display diff inside a window, could somebody help me with this?

@Asalle Asalle requested a review from nevenz January 17, 2020 20:58
@Asalle Asalle mentioned this pull request Jan 18, 2020
1 task
@nevenz
Copy link
Member

nevenz commented Feb 3, 2020

I don't think this should be git-specific, but available for any repository type. That would require keeping the synced files around (which is probably a good idea anyway) and using them to generate the diff. Maybe using something like https://github.com/java-diff-utils/java-diff-utils ?

@Asalle
Copy link
Author

Asalle commented Feb 3, 2020 via email

@Asalle
Copy link
Author

Asalle commented Feb 23, 2020

@nevenz that is true, i should implement it for all repos, not just git, I myself don't use git 😅
Can anybody provide any mentoring on this? Right now I'm planning to do this:

  1. Add function StoreBooks to SyncRepo interface and use it to download all remote books to some local folder
  2. Find a place where the sync happens (working on this rn) and instead of syncing with remote, fetch the remote notebooks first and then sync them. If any merge conficts appear - show diff.

@nevenz
Copy link
Member

nevenz commented Feb 24, 2020

I don't think there's a need for changing the interface. As you suggest in #2, we can simply keep already used notebooks files around. See the creation and deletion of temporary files in loadBookFromRepo and saveBookToRepo.

@Asalle
Copy link
Author

Asalle commented May 10, 2020

@nevenz on latest upsteam/master I cannot sync with dropbox, only webdav and directory, am I doing something wrong?

@nevenz
Copy link
Member

nevenz commented May 10, 2020

on latest upsteam/master I cannot sync with dropbox, only webdav and directory, am I doing something wrong?

Check the build variant you're using. Perhaps it's one of the fdroid* ?

@Asalle
Copy link
Author

Asalle commented May 10, 2020

yup, that was the reason. Thanks!

@yamsu
Copy link

yamsu commented Jun 4, 2020

This would be a really useful addition to the feature set. Syncing issues are very common when using dropbox integration, as sync has to be manually activated.

Looking forward to this merge.

@Asalle
Copy link
Author

Asalle commented Oct 18, 2022

damn, I don't remember closing this!

@Asalle
Copy link
Author

Asalle commented Oct 21, 2022

damn, I might have accidentally overwritten my master branch (who even does work on master, jeesh!)
Trying to work on it, living ALL THESE YEARS without diff is hard... Any help welcome!

@Asalle Asalle reopened this Oct 21, 2022
@berteh
Copy link

berteh commented Nov 7, 2022

+1
this feature would be most useful. thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync diff
4 participants